Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a TableEmptyMessage attribute #303

Open
wants to merge 4 commits into
base: 4.x
Choose a base branch
from
Open

Conversation

greg-1-anderson
Copy link
Member

Disposition

This pull request:

  • Fixes a bug
  • Adds a feature
  • Breaks backwards compatibility
  • Has tests that cover changes

Summary

Add a #[CLI\TableEmptyMessage] attribute that allows commands to specify what message to print when the table is empty. Provide an empty string for message to print nothing.

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.19%. Comparing base (e01152f) to head (173ca51).
Report is 2 commits behind head on 4.x.

❗ Current head 173ca51 differs from pull request most recent head 0ca3a27. Consider uploading reports for the commit 0ca3a27 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##                4.x     #303   +/-   ##
=========================================
  Coverage     88.19%   88.19%           
  Complexity      781      781           
=========================================
  Files            46       46           
  Lines          2100     2100           
=========================================
  Hits           1852     1852           
  Misses          248      248           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@weitzman weitzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants