Allow Symfony 7 (4.x) #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
…he alias is not found (Symfony will prompt for which command you might want to run instead in this instance).
…very rare?) should override "execute". Not sure why it worked any other way in the past.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #308 +/- ##
=========================================
Coverage 88.19% 88.19%
Complexity 781 781
=========================================
Files 46 46
Lines 2100 2100
=========================================
Hits 1852 1852
Misses 248 248 ☔ View full report in Codecov by Sentry. |
| @@ -44,7 +44,7 @@ public function myEcho($one, $two = '', $multiple = [], $flip = false) | |||
| * @usage bet alpha --flip | |||
| * Concatenate "alpha" and "bet". | |||
| */ | |||
| protected function execute(InputInterface $input, OutputInterface $output) | |||
| protected function myEchoAnnotated(InputInterface $input, OutputInterface $output) | |||
There was a problem hiding this comment.
This method must be named execute for this test.
There was a problem hiding this comment.
OK, methods named execute will have to add a return type hint.
There was a problem hiding this comment.
Did that, seems green now, I guess old versions are passing because it is okay to add a function return type in an overriding class even if the base class didn't have it.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disposition
This pull request:
Summary
Short overview of what changed.
Description
Any additional information.