From 23b1a396239c088eaa3bc79bf0a938e72a2fc753 Mon Sep 17 00:00:00 2001 From: melontini <104443436+melontini@users.noreply.github.com> Date: Mon, 17 Jul 2023 06:39:26 +0700 Subject: [PATCH 1/2] Fixed lack of name on item groups --- .../java/me/melontini/dark_matter/content/ContentBuilder.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dark-matter-content/src/main/java/me/melontini/dark_matter/content/ContentBuilder.java b/dark-matter-content/src/main/java/me/melontini/dark_matter/content/ContentBuilder.java index 661b5f51..d513103b 100644 --- a/dark-matter-content/src/main/java/me/melontini/dark_matter/content/ContentBuilder.java +++ b/dark-matter-content/src/main/java/me/melontini/dark_matter/content/ContentBuilder.java @@ -3,6 +3,7 @@ import com.mojang.datafixers.types.Type; import me.melontini.dark_matter.DarkMatterLog; import me.melontini.dark_matter.content.interfaces.AnimatedItemGroup; +import me.melontini.dark_matter.minecraft.util.TextUtil; import me.melontini.dark_matter.util.MakeSure; import me.melontini.dark_matter.util.Utilities; import net.fabricmc.api.EnvType; @@ -282,7 +283,7 @@ public ItemGroup build() { }); builder.icon(() -> ItemGroupBuilder.this.icon.get()); - if (this.displayName != null) builder.displayName(this.displayName); + builder.displayName(Objects.requireNonNullElseGet(this.displayName, () -> TextUtil.translatable("itemGroup." + this.identifier.toString().replace(":", ".")))); if (this.texture != null) builder.texture(this.texture); ItemGroup group = builder.build(); From 445652d799202577a6c474a51134fde50f04f6a1 Mon Sep 17 00:00:00 2001 From: melontini <104443436+melontini@users.noreply.github.com> Date: Mon, 17 Jul 2023 06:42:04 +0700 Subject: [PATCH 2/2] CHANGELOG.md --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index f6b5ad2a..9e7265a2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ ## What's new: +### Content + +* Fixed item groups not having a name by default. (1.19.3+) + ### Danger * Fixed InstrumentationAccess failing to locate the agent jar.