Skip to content

Commit

Permalink
Add source_volume_group_id to ListVolumeGroupSnapshotsRequest
Browse files Browse the repository at this point in the history
  • Loading branch information
xing-yang committed Nov 21, 2022
1 parent 9e71705 commit 2dd3e15
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 12 deletions.
18 changes: 12 additions & 6 deletions csi.proto
Original file line number Diff line number Diff line change
Expand Up @@ -136,13 +136,14 @@ service Controller {
option (alpha_method) = true;
}

rpc GetVolumeGroup(GetVolumeGroupRequest)
returns (GetVolumeGroupResponse) {
rpc ControllerGetVolumeGroup(ControllerGetVolumeGroupRequest)
returns (ControllerGetVolumeGroupResponse) {
option (alpha_method) = true;
}

rpc GetVolumeGroupSnapshot(GetVolumeGroupSnapshotRequest)
returns (GetVolumeGroupSnapshotResponse) {
rpc ControllerGetVolumeGroupSnapshot(
ControllerGetVolumeGroupSnapshotRequest)
returns (ControllerGetVolumeGroupSnapshotResponse) {
option (alpha_method) = true;
}
}
Expand Down Expand Up @@ -1103,7 +1104,7 @@ message VolumeGroup {
// This field is REQUIRED.
// To support the creation of an empty group, this list can be empty.
// However, this field is not empty in the following cases:
// - Response from ListVolumeGroups or GetVolumeGroup if the
// - Response from ListVolumeGroups or ControllerGetVolumeGroup if the
// VolumeGroup is not empty.
// - Response from ModifyVolumeGroup if the VolumeGroup is not
// empty after modification.
Expand Down Expand Up @@ -1346,11 +1347,16 @@ message ListVolumeGroupSnapshotsRequest {
// An empty string is equal to an unspecified field value.
string starting_token = 2;

// Identity information for the source volume group.
// This field is OPTIONAL.
// It can be used to list group snapshots by volume group.
string source_volume_group_id = 3;

// Secrets required by plugin to complete ListVolumeGroupSnapshot
// request.
// This field is OPTIONAL. Refer to the `Secrets Requirements`
// section on how to use this field.
map<string, string> secrets = 3 [(csi_secret) = true];
map<string, string> secrets = 4 [(csi_secret) = true];
}

message ListVolumeGroupSnapshotsResponse {
Expand Down
18 changes: 12 additions & 6 deletions spec.md
Original file line number Diff line number Diff line change
Expand Up @@ -417,13 +417,14 @@ service Controller {
option (alpha_method) = true;
}
rpc GetVolumeGroup(GetVolumeGroupRequest)
returns (GetVolumeGroupResponse) {
rpc ControllerGetVolumeGroup(ControllerGetVolumeGroupRequest)
returns (ControllerGetVolumeGroupResponse) {
option (alpha_method) = true;
}
rpc GetVolumeGroupSnapshot(GetVolumeGroupSnapshotRequest)
returns (GetVolumeGroupSnapshotResponse) {
rpc ControllerGetVolumeGroupSnapshot(
ControllerGetVolumeGroupSnapshotRequest)
returns (ControllerGetVolumeGroupSnapshotResponse) {
option (alpha_method) = true;
}
}
Expand Down Expand Up @@ -1780,7 +1781,7 @@ message VolumeGroup {
// This field is REQUIRED.
// To support the creation of an empty group, this list can be empty.
// However, this field is not empty in the following cases:
// - Response from ListVolumeGroups or GetVolumeGroup if the
// - Response from ListVolumeGroups or ControllerGetVolumeGroup if the
// VolumeGroup is not empty.
// - Response from ModifyVolumeGroup if the VolumeGroup is not
// empty after modification.
Expand Down Expand Up @@ -2181,11 +2182,16 @@ message ListVolumeGroupSnapshotsRequest {
// An empty string is equal to an unspecified field value.
string starting_token = 2;
// Identity information for the source volume group.
// This field is OPTIONAL.
// It can be used to list group snapshots by volume group.
string source_volume_group_id = 3;
// Secrets required by plugin to complete ListVolumeGroupSnapshot
// request.
// This field is OPTIONAL. Refer to the `Secrets Requirements`
// section on how to use this field.
map<string, string> secrets = 3 [(csi_secret) = true];
map<string, string> secrets = 4 [(csi_secret) = true];
}
message ListVolumeGroupSnapshotsResponse {
Expand Down

0 comments on commit 2dd3e15

Please sign in to comment.