From 2dd3e15a69ccb213c52321f2f4af519226311551 Mon Sep 17 00:00:00 2001
From: xing-yang <xingyang105@gmail.com>
Date: Mon, 26 Sep 2022 17:05:57 -0400
Subject: [PATCH] Add source_volume_group_id to ListVolumeGroupSnapshotsRequest

---
 csi.proto | 18 ++++++++++++------
 spec.md   | 18 ++++++++++++------
 2 files changed, 24 insertions(+), 12 deletions(-)

diff --git a/csi.proto b/csi.proto
index 1add9409..87e56ede 100644
--- a/csi.proto
+++ b/csi.proto
@@ -136,13 +136,14 @@ service Controller {
         option (alpha_method) = true;
     }
 
-  rpc GetVolumeGroup(GetVolumeGroupRequest)
-    returns (GetVolumeGroupResponse) {
+  rpc ControllerGetVolumeGroup(ControllerGetVolumeGroupRequest)
+    returns (ControllerGetVolumeGroupResponse) {
         option (alpha_method) = true;
     }
 
-  rpc GetVolumeGroupSnapshot(GetVolumeGroupSnapshotRequest)
-    returns (GetVolumeGroupSnapshotResponse) {
+  rpc ControllerGetVolumeGroupSnapshot(
+        ControllerGetVolumeGroupSnapshotRequest)
+    returns (ControllerGetVolumeGroupSnapshotResponse) {
         option (alpha_method) = true;
     }
 }
@@ -1103,7 +1104,7 @@ message VolumeGroup {
   // This field is REQUIRED.
   // To support the creation of an empty group, this list can be empty.
   // However, this field is not empty in the following cases:
-  // - Response from ListVolumeGroups or GetVolumeGroup if the
+  // - Response from ListVolumeGroups or ControllerGetVolumeGroup if the
   //   VolumeGroup is not empty.
   // - Response from ModifyVolumeGroup if the VolumeGroup is not
   //   empty after modification.
@@ -1346,11 +1347,16 @@ message ListVolumeGroupSnapshotsRequest {
   // An empty string is equal to an unspecified field value.
   string starting_token = 2;
 
+  // Identity information for the source volume group.
+  // This field is OPTIONAL.
+  // It can be used to list group snapshots by volume group.
+  string source_volume_group_id = 3;
+
   // Secrets required by plugin to complete ListVolumeGroupSnapshot
   // request.
   // This field is OPTIONAL. Refer to the `Secrets Requirements`
   // section on how to use this field.
-  map<string, string> secrets = 3 [(csi_secret) = true];
+  map<string, string> secrets = 4 [(csi_secret) = true];
 }
 
 message ListVolumeGroupSnapshotsResponse {
diff --git a/spec.md b/spec.md
index 53f962c2..5f2684af 100644
--- a/spec.md
+++ b/spec.md
@@ -417,13 +417,14 @@ service Controller {
         option (alpha_method) = true;
     }
 
-  rpc GetVolumeGroup(GetVolumeGroupRequest)
-    returns (GetVolumeGroupResponse) {
+  rpc ControllerGetVolumeGroup(ControllerGetVolumeGroupRequest)
+    returns (ControllerGetVolumeGroupResponse) {
         option (alpha_method) = true;
     }
 
-  rpc GetVolumeGroupSnapshot(GetVolumeGroupSnapshotRequest)
-    returns (GetVolumeGroupSnapshotResponse) {
+  rpc ControllerGetVolumeGroupSnapshot(
+        ControllerGetVolumeGroupSnapshotRequest)
+    returns (ControllerGetVolumeGroupSnapshotResponse) {
         option (alpha_method) = true;
     }
 }
@@ -1780,7 +1781,7 @@ message VolumeGroup {
   // This field is REQUIRED.
   // To support the creation of an empty group, this list can be empty.
   // However, this field is not empty in the following cases:
-  // - Response from ListVolumeGroups or GetVolumeGroup if the
+  // - Response from ListVolumeGroups or ControllerGetVolumeGroup if the
   //   VolumeGroup is not empty.
   // - Response from ModifyVolumeGroup if the VolumeGroup is not
   //   empty after modification.
@@ -2181,11 +2182,16 @@ message ListVolumeGroupSnapshotsRequest {
   // An empty string is equal to an unspecified field value.
   string starting_token = 2;
 
+  // Identity information for the source volume group.
+  // This field is OPTIONAL.
+  // It can be used to list group snapshots by volume group.
+  string source_volume_group_id = 3;
+
   // Secrets required by plugin to complete ListVolumeGroupSnapshot
   // request.
   // This field is OPTIONAL. Refer to the `Secrets Requirements`
   // section on how to use this field.
-  map<string, string> secrets = 3 [(csi_secret) = true];
+  map<string, string> secrets = 4 [(csi_secret) = true];
 }
 
 message ListVolumeGroupSnapshotsResponse {