Skip to content

Commit

Permalink
Regenerate with protoc-gen-go 1.3.5
Browse files Browse the repository at this point in the history
go.mod has github.com/golang/protobuf 1.5.3, which has a protoc-gen-go that is
not compatible with csi.pb.go in this repo.

Download github.com/golang/protobuf v1.3.5 separately, build
protoc-gen-go from it and use it to generate csi.pb.go.

The code is copied from the previous release of CSI spec, only with minor
changes.

A future update to 1.5.3 must be done carefuly and announce a breaking change.
  • Loading branch information
jsafrane committed Aug 30, 2024
1 parent 2f34062 commit a79e25c
Show file tree
Hide file tree
Showing 2 changed files with 3,690 additions and 6,938 deletions.
3 changes: 2 additions & 1 deletion lib/go/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ PROTOC_TMP_DIR := .protoc
PROTOC := $(PROTOC_TMP_DIR)/bin/protoc

$(GOBIN)/protoc-gen-go: ../../go.mod
go install google.golang.org/protobuf/cmd/protoc-gen-go
go install github.com/golang/protobuf/protoc-gen-go@v1.3.5

$(GOBIN)/protoc-gen-go-grpc:
go install google.golang.org/grpc/cmd/protoc-gen-go-grpc@v1.3.0

Expand Down
Loading

0 comments on commit a79e25c

Please sign in to comment.