Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow konflux images with oci index, be used in osbs #2122

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Allow konflux images with oci index, be used in osbs #2122

merged 1 commit into from
Oct 25, 2024

Conversation

rcerven
Copy link
Member

@rcerven rcerven commented Oct 22, 2024 •
edited by MartinBasti
Loading

  • STONEBLD-2896

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • Python type annotations added to new code
  • JSON/YAML configuration changes are updated in the relevant schema
  • Changes to metadata also update the documentation for the metadata
  • Pull request has a link to an osbs-docs PR for user documentation updates
  • New feature can be disabled from a configuration file

@rcerven rcerven force-pushed the basekonflux branch 5 times, most recently from 880a392 to 967b5dc Compare October 23, 2024 17:03
@MartinBasti
Copy link
Contributor

mypy is failing

@rcerven rcerven requested a review from mkosiarc October 24, 2024 14:32
@rcerven
Copy link
Member Author

rcerven commented Oct 24, 2024

mypy is failing

fixed

@MartinBasti
Copy link
Contributor

Commit message could describe better what is changed and why

@rcerven
Allow konflux images with oci index, be used in osbs
1ee6ce8 
Don't explicitly require parent images to be found it koji
and lower waiting time for trying to get koji build

* STONEBLD-2896

Signed-off-by: Robert Cerven <rcerven@redhat.com>
chmeliik
chmeliik approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming the handling for Konflux SBOMs will be a separate PR

@rcerven rcerven merged commit 742b441 into containerbuildsystem:master Oct 25, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chmeliik chmeliik chmeliik approved these changes

@MartinBasti MartinBasti MartinBasti approved these changes

@mkosiarc mkosiarc Awaiting requested review from mkosiarc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rcerven @MartinBasti @chmeliik