-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sync code from runc shim #155
Conversation
@jsturtevant any ideas why windows integration tests fail? Not sure I get what exactly wrong with it and I don't have windows env to verify (this also fails in
|
looks like bringing in the
Looks like main is failing due to #160? |
Let me rebase this and give it another try. |
d5b811e
to
7b07c04
Compare
rebase didn't help 😞. CI on main is passing today: https://github.com/containerd/rust-extensions/actions/runs/5743079375 and I was able to run the integration test locally on main. Going to pull this PR to see I can track down what is causing the mix up |
Still tracking down what is happening but but |
@mxpv I don't know why but it seems the examples are getting the If I run rust-extensions/.github/workflows/ci-windows.yml Lines 97 to 99 in 27a503a
|
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
@jsturtevant That did the trick! |
LGTM |
Closes: #134