-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update tonic
and prost
dependencies to latest
#307
Conversation
fa24b0a
to
f42a340
Compare
ed4c2ee
to
5ddcc95
Compare
Hello, I was wondering what's the status of this PR, as I came across the need for this upgrade. Thanks, keep up the great work :) |
5ddcc95
to
2035606
Compare
@@ -1,3 +1,3 @@ | |||
[toolchain] | |||
channel = "1.74" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
min version that resolved this error:
error: unsupported output in build script of `containerd-client v0.5.0 (/Users/runner/work/rust-extensions/rust-extensions/crates/client)`: `cargo::rerun-if-changed=vendor/github.com/containerd/containerd/api/types/descriptor.proto`
Found a `cargo::key=value` build directive which is reserved for future use.
Either change the directive to `cargo:key=value` syntax (note the single `:`) or upgrade your version of Rust.
See https://doc.rust-lang.org/cargo/reference/build-scripts.html#outputs-of-the-build-script for more information about build script outputs.
warning: build failed, waiting for other jobs to finish...
bd742f5
to
ed79109
Compare
@jsturtevant any suggestions on how to deal with this https://github.com/containerd/rust-extensions/actions/runs/10822451454/job/30026310388?pr=307 |
@bryantbiggs I think you should use |
ya, let me fire up a windows VM and try fumbling around a bit with this one so maybe we can finally get it across the line 😅 |
Co-authored-by: James Sturtevant <jsturtevant@gmail.com> Signed-off-by: Bryant Biggs <bryantbiggs@gmail.com>
…=value` build directive which is reserved for future use
ed79109
to
0e5c8cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Thanks!
@mxpv can we have a release for containerd-client please? |
On Oct 6, 2024, at 11:21 PM, Aviram Hassan ***@***.***> wrote:
@mxpv <https://github.com/mxpv> can we have a release for containerd-client please?

|
Closes #286
Closes #287
Closes #288
Closes #289
Ref: hyperium/hyper#3110