Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INIT Verb for CNI 1.1 #975

Open
MikeZappa87 opened this issue Mar 6, 2023 · 5 comments
Open

INIT Verb for CNI 1.1 #975

MikeZappa87 opened this issue Mar 6, 2023 · 5 comments
Assignees
Milestone

Comments

@MikeZappa87
Copy link
Contributor

MikeZappa87 commented Mar 6, 2023

We have come to the conclusion that INIT should be implemented in the CNI. To do this we need to do the following.

  1. Come up with use cases
  2. Propose a spec change (Inputs, Outputs, Error Codes ... )
  3. Implement the change in libcni
  4. Implement in reference plugins (if applicable)
@MikeZappa87 MikeZappa87 added this to the CNI v1.1 milestone Mar 6, 2023
@MikeZappa87 MikeZappa87 self-assigned this Mar 6, 2023
@s1061123
Copy link
Contributor

s1061123 commented Mar 20, 2023

Just a note:

INIT (and DEINIT if we need) implementation requires lock mechanism in libcni or CNI plugin because libcni may be invoked twice or more at same time. To prevent race condition, we need some lock before INIT is invoked, somewhere, hence we may require

  • add lock mechanism in libcni (i.e. implement lock in libcni side), or
  • clearly mention to require lock mechanism in SPEC.md (for CNI plugins which uses INIT, i.e. implement lock in plugin side)

@MikeZappa87
Copy link
Contributor Author

What if we call INIT when the network configuration is loaded by the container runtime? Prior the configuration being loaded, the runtime is not able to schedule containers

@squeed
Copy link
Member

squeed commented Jul 4, 2023

At this point, I think we should drop INIT from v1.1. There are enough other things in this release. Thoughts?

@MikeZappa87
Copy link
Contributor Author

Let’s push it and get some feedback

@squeed squeed modified the milestones: CNI v1.1, CNI v1.2 Oct 2, 2023
@squeed
Copy link
Member

squeed commented Jun 24, 2024

This is still awaiting some kind of motivating story; we have nothing against it, but it needs a bit more possible use-cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants