defaulting no option but allow override chat format #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gregory-Pereira
requested review from
MichaelClifford,
rhatdan,
sallyom,
lmilbaum and
cgwalters
as code owners
jeffmaury
reviewed
Jun 7, 2024
Signed-off-by: greg pereira <grpereir@redhat.com>
Gregory-Pereira
force-pushed
the
default-chat-template-to-model-meta
branch
from
9882e59
to
65f265a
Compare
rhatdan
reviewed
Jun 10, 2024
| @@ -1,5 +1,5 @@ | |||
| FROM registry.access.redhat.com/ubi9/python-311:1-62.1716478620 | |||
| ENV CHAT_FORMAT=llama-2 | |||
| ENV CHAT_FORMAT= | |||
There was a problem hiding this comment.
I don't believe this works as you expect? IE if I do
make CHAT_FORMAT=foobar, I don't think the CHAT_FORMAT variable in the podman build will get passed in.
There was a problem hiding this comment.
Understood. I can remove it, which just means we have no ability to set it at the build stage but we can default the option at the run stage. Updated in: 558ecaf
Signed-off-by: greg pereira <grpereir@redhat.com>
Gregory-Pereira
force-pushed
the
default-chat-template-to-model-meta
branch
from
50bd7aa
to
558ecaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: https://redhat-internal.slack.com/archives/C06S75ZF9JT/p1717582264034089