Fix Makefiles to allow alternative container engines #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhatdan
requested review from
MichaelClifford,
sallyom,
lmilbaum,
cgwalters and
Gregory-Pereira
as code owners
Some users want to use buildah instead of podman to build their container engines. Buildah does not support --squash-all but after examining the podman code --squash-all ends up just being the equivalent of "--squash --layers=false" Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Gregory-Pereira
approved these changes
Jun 9, 2024
| @@ -16,7 +16,7 @@ run: | |||
| # rag requires custom bootc because it uses an extra build-arg for CHROMADB_IMAGE (other apps use ../../common/Makefile.common target) | |||
| .PHONY: bootc | |||
| bootc: quadlet | |||
| podman build \ | |||
| "${CONTAINER_TOOL}" build \ | |||
There was a problem hiding this comment.
Did we want to include the --layers=false in this bootc command?
There was a problem hiding this comment.
We are not squashing so no.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users want to use buildah instead of podman to build their container engines.
Buildah does not support --squash-all but after examining the podman code --squash-all ends up just being the equivalent of "--squash --layers=false"