Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable ginkgolinter and testifylint #1893

Open
Luap99 opened this issue Mar 6, 2024 · 2 comments
Open

enable ginkgolinter and testifylint #1893

Luap99 opened this issue Mar 6, 2024 · 2 comments

Comments

@Luap99
Copy link
Member

Luap99 commented Mar 6, 2024

These linters provide helpful warnings to write better error assertions in case tests fail.
Right now there are a lot of report errors with them.
@nunnatsa
Copy link

nunnatsa commented Mar 6, 2024 •
edited
Loading

About ginkgolinter, many of its warnings can be auto fixef by the ginkgolinter cmd. (golangci-lint does not support auto fix).

@Luap99
Copy link
Member Author

Luap99 commented Mar 6, 2024

Yes thanks for the very useful linter! I am aware of the auto fix option as I used it on Podman before and it was super helpful.

@Luap99 Luap99 mentioned this issue Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Luap99 @nunnatsa