Manually added code to otherwise gperf-generated src/libcrun/mount_flags.c

[paravoid]

Commit 366af73 (PR #1237 / issue #1177), included in v1.8.6, added the function get_mount_flags_from_wordlist() to src/libcrun/mount_flags.c (and the prototype to src/libcrun/mount_flags.h).

However, src/libcrun/mount_flags.c is supposed to be automatically generated with gperf and the generated copy is only included for convenience, AIUI.

Regenerating the file with with make generate-mount_flags.c (i.e. gperf), results in a diff to mount_flags.c, where this function is removed. No other functional changes currently exist with gperf 3.1, just whitespace differences.

Not sure what the right fix is here and where this function should be moved.

Besides the fix to address the symptom, something should probably be done to avoid the gperf source and the generated files drifting from each other again. Perhaps some kind of CI check, but this can be tricky given there are whitespace changes between gperf versions. Alternatively, perhaps just add gperf as a build dependency and just always regenerate the two files? Note that this this exactly what we're doing in the Debian package, for freeness/preferred source of modification reasons.

[giuseppe]

Thanks for the report.

We can add the function directly to the .perf file. Opened a PR to fix it: #1266