Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gvproxy: Cannot disable 'ssh-port' forwarding #402

Open
cfergeau opened this issue Sep 25, 2024 · 1 comment
Open

gvproxy: Cannot disable 'ssh-port' forwarding #402

cfergeau opened this issue Sep 25, 2024 · 1 comment

Comments

@cfergeau
Copy link
Contributor

When starting gvproxy, if -ssh-port is not specified, host port 2222 will be opened and will link to port 22 in the VM.
In some cases, it could be desirable to disable this entirely. This could be done by passing -1 as the port number.
I prefer not to change the behaviour of gvproxy when --ssh-port is not specified out of backwards compat concerns.
@cfergeau
Copy link
Contributor Author

This would be useful in containers/podman#20327

cfergeau added a commit to cfergeau/podman that referenced this issue Sep 25, 2024
@cfergeau
wsl: usernet: Don't always bind to port 2222
f916de1 
podman-machine starts gvproxy without specifying -ssh-port.
This means it will always bind port 2222 (see
containers/gvisor-tap-vsock#402), effectively
bypassing the dynamic ssh port allocation.

I don't think wsl needs this port to be opened/bound on the host, but
this commit starts gvproxy with -ssh-port set to the dynamic SSH port to
avoid port conflicts with crc.
When gvproxy allows to disable this port forwarding entirely, we can
revise this.

This should fix containers#20327

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
@cfergeau cfergeau mentioned this issue Sep 25, 2024
Open
cfergeau added a commit to cfergeau/podman that referenced this issue Sep 25, 2024
@cfergeau
wsl: usernet: Don't always bind to port 2222
af1270b 
podman-machine starts gvproxy without specifying -ssh-port.
This means it will always bind port 2222 (see
containers/gvisor-tap-vsock#402), effectively
bypassing the dynamic ssh port allocation.

I don't think wsl needs this port to be opened/bound on the host, but
this commit starts gvproxy with -ssh-port set to the dynamic SSH port to
avoid port conflicts with crc.
When gvproxy allows to disable this port forwarding entirely, we can
revise this.

This should fix containers#20327

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
@cfergeau cfergeau assigned cfergeau and unassigned cfergeau Oct 1, 2024
@vyasgun vyasgun mentioned this issue Oct 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cfergeau