packit: Build PRs into default packit COPRs #254
Conversation
|
I'm afraid I'll need help with this test failure. Is this fallout from building against podman-next instead of packit-builds COPR? I.e. depending on some PR that didn't land yet? |
Building all PRs of all container projects into the same COPR does not properly isolate PRs from each other. To avoid that, change the copr_build configuration to use the packit default COPRs, which are specific to the particular PR, and disappear after a few weeks. Depending projects should only run against what landed in gvisor-tap-vsock/main i.e. the podman-next COPR. Unmerging the two copr jobs allows us the redundant targets: list for the "main" builds into podman-next. Specifying the target list is not necessary any more since packit/packit-service#1499 got fixed. Signed-off-by: Martin Pitt <mpitt@redhat.com>
|
Nevermind, it was a flake. I needed to re-push for fixing a small copy pasta in the commit message. All green now. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lsm5, martinpitt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Merged it, thanks! |
Building all PRs of all container projects into the same COPR does not properly isolate PRs from each other.
To avoid that, change the copr_build configuration to use the packit default COPRs, which are specific to the particular PR, and disappear after a few weeks. Depending projects should only run against what landed in gvisor-tap-vsock/main i.e. the podman-next COPR.
Unmerging the two copr jobs allows us the redundant targets: list for the "main" builds into podman-next. Specifying the target list is not necessary any more since packit/packit-service#1499 got fixed.
This is exactly the same as containers/crun#1260 ; please see the discussion there, this change needs to be applied to all container projects, and then all land together. Let's keep all the relevant discussions and tracking in the crun PR please.