.github: add workflow for rejecting PRs that introduce whitespace errors. #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
klihub
commented
Oct 24, 2023
klihub
commented
- add workflow to check and reject PRs that introduce trailing WS errors (or conflict markers)
- add in-repo .githooks with a hook to check trailing whitespace and conflict marker errors
- add Makefile target to enable in-repo githooks
klihub
force-pushed
the
fixes/reject-whitespace-errors
branch
from
a068b0a
to
19a36ca
Compare
marquiz
reviewed
Oct 24, 2023
klihub
changed the title
marquiz
reviewed
Oct 24, 2023
marquiz
reviewed
Oct 24, 2023
Add trailing whitespace error check to our project-checks workflow. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
klihub
force-pushed
the
fixes/reject-whitespace-errors
branch
from
19a36ca
to
8f717f9
Compare
Add pre-commit git hook to check for trailing whitespace. Add Makefile target 'install-git-hooks' for enabling in- repo (pre-commit) git hooks. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
klihub
force-pushed
the
fixes/reject-whitespace-errors
branch
from
8f717f9
to
4746de2
Compare
marquiz
reviewed
Oct 24, 2023
| *~|*.swp) | ||
| continue | ||
| ;; | ||
| [0-9]*-*) |
There was a problem hiding this comment.
Maybe we should document somehow (more clearly, somewhere), that the hooks in the drop-in dir have strict naming requirements (otherwise they are silently ignored). WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.