Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: adjust $VM_HOSTNAME for policy node config usage. #378

Merged

Conversation

klihub
Copy link
Collaborator

@klihub klihub commented Oct 4, 2024

Take into account that $VM_HOSTNAME's like xyzzy-foobar-22.04 will propagate to the VM distro hostname as xyzzy-foobar-22.

Copy link
Collaborator

@kad kad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/e2e/run.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking to "Request changes" to prevent merging by accident.

Take into account that $VM_HOSTNAME's like xyzzy-foobar-22.04
will propagate to the VM distro hostname as xyzzy-foobar-22.

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub klihub force-pushed the fixes/e2e/fix-vm-hostname-propagation branch from bbce780 to b10c267 Compare October 7, 2024 08:18
@klihub klihub requested a review from askervin October 7, 2024 08:18
Copy link
Collaborator

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@askervin askervin merged commit 572c29c into containers:main Oct 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants