Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle kubernetes connection in startProvider function #8629

Merged
merged 1 commit into from
Aug 30, 2024
Merged

fix: handle kubernetes connection in startProvider function #8629

merged 1 commit into from
Aug 30, 2024

Conversation

lstocchi
Copy link
Contributor

What does this PR do?

This PR enhances the startProvider function to check for kubernetes connections as well. This would fix an issue faced on crc

Screenshot / video of UI

N/A

What issues does this PR fix or reference?

it resolves #8514

How to test this PR?

  1. run tests
  2. or by using fix: handle error so that it is shown in both page and task manager crc-org/crc-extension#247 try to execute initialize and start from the dashboard.
  • Tests are covering the bug fix or the new feature

@lstocchi
fix: handle kubernetes connection in startProvider function
dfbd34a 
Signed-off-by: lstocchi <lstocchi@redhat.com>
@lstocchi lstocchi requested review from benoitf and a team as code owners August 28, 2024 13:39
@lstocchi lstocchi requested review from jeffmaury, cdrage, axel7083 and dgolovin and removed request for a team August 28, 2024 13:39
@lstocchi
Copy link
Contributor Author

@dgolovin @jeffmaury -> for crc-org/crc-extension#247 in crc

jeffmaury
jeffmaury approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lstocchi lstocchi merged commit 2b320e5 into containers:main Aug 30, 2024
7 checks passed
@lstocchi lstocchi deleted the i8514 branch August 30, 2024 07:10
@podman-desktop-bot podman-desktop-bot added this to the 1.13.0 milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@jeffmaury jeffmaury jeffmaury approved these changes

@cdrage cdrage Awaiting requested review from cdrage cdrage is a code owner automatically assigned from containers/podman-desktop-reviewers

@axel7083 axel7083 Awaiting requested review from axel7083 axel7083 is a code owner automatically assigned from containers/podman-desktop-reviewers

@dgolovin dgolovin Awaiting requested review from dgolovin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Run ${providerName} button on dashboard provider card does not work for kubernetes connections
4 participants
@lstocchi @benoitf @jeffmaury @podman-desktop-bot