Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display files added/removed/modified by image layers #9175

Merged
merged 1 commit into from
Oct 2, 2024
Merged

feat: display files added/removed/modified by image layers #9175

merged 1 commit into from
Oct 2, 2024

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Oct 2, 2024 •
edited
Loading

Signed-off-by: Philippe Martin phmartin@redhat.com

What does this PR do?

Display the number of files added/modified/removed in each image layer.

Screenshot / video of UI

layer-files-changes

What issues does this PR fix or reference?

Fixes #8925
Related to containers/podman-desktop-extension-layers-explorer#57

How to test this PR?

Build a test image with:

FROM busybox
RUN echo -n 1 > 1.txt
RUN echo -n 12 > 2.txt
RUN echo -n 123 > 3.txt
RUN echo -n 123456 > 3.txt
RUN echo -n 123 > 3.txt
RUN rm 2.txt && echo -n 1234 > 4.txt && echo 12345 > 3.txt
  • Tests are covering the bug fix or the new feature

@feloy feloy requested review from benoitf and a team as code owners October 2, 2024 14:32
@feloy feloy requested review from jeffmaury, cdrage and axel7083 and removed request for a team October 2, 2024 14:32
@benoitf
Copy link
Collaborator

benoitf commented Oct 2, 2024

works for me

@feloy
feat: display files added/removed/modified
c59d134 
Signed-off-by: Philippe Martin <phmartin@redhat.com>
@feloy feloy force-pushed the feat-8925/update-layer-size-display-2 branch from 157ea66 to c59d134 Compare October 2, 2024 15:23
cdrage
cdrage approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works absolutely awesome. This extension rocks!

Code LGTM and tested it locally.

@cdrage cdrage merged commit c8fded5 into containers:main Oct 2, 2024
15 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.13.0 milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@cdrage cdrage cdrage approved these changes

@jeffmaury jeffmaury Awaiting requested review from jeffmaury jeffmaury is a code owner automatically assigned from containers/podman-desktop-reviewers

@axel7083 axel7083 Awaiting requested review from axel7083 axel7083 is a code owner automatically assigned from containers/podman-desktop-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Update display of layer size
4 participants
@feloy @benoitf @cdrage @podman-desktop-bot