Improve the error message when running nested inside a non-Toolbx container #1295
Conversation
nievesmontero
force-pushed
the
improve-error-message
branch
from
9598f72
to
34e4d3c
Compare
|
Build failed. ✔️ unit-test SUCCESS in 9m 32s |
nievesmontero
force-pushed
the
improve-error-message
branch
from
34e4d3c
to
29f6166
Compare
|
Build failed. ✔️ unit-test SUCCESS in 9m 44s |
nievesmontero
force-pushed
the
improve-error-message
branch
from
29f6166
to
7ec40bb
Compare
|
Build failed. ✔️ unit-test SUCCESS in 9m 21s |
nievesmontero
force-pushed
the
improve-error-message
branch
from
7ec40bb
to
a00bedc
Compare
|
Build succeeded. ✔️ unit-test SUCCESS in 9m 16s |
nievesmontero
force-pushed
the
improve-error-message
branch
from
a00bedc
to
43a745f
Compare
|
Build failed. ❌ unit-test FAILURE in 9m 18s |
nievesmontero
force-pushed
the
improve-error-message
branch
from
43a745f
to
36975c2
Compare
|
Build failed. ✔️ unit-test SUCCESS in 9m 46s |
nievesmontero
force-pushed
the
improve-error-message
branch
from
36975c2
to
fcb73d2
Compare
|
Build failed. ✔️ unit-test SUCCESS in 9m 29s |
There was a problem hiding this comment.
Is this a continuation of #1191 ? It would have been better to continue using the old pull request to keep all the discussion in one place.
Anyway, the tests are failing, and the branch has conflicts. Did you check the test logs to understand why they are failing? The tests really need to pass.
I paused this PR and moved to #1301 to first fix the tests. I expect this PR to be fixed once #1301 is fixed. |
Did the tests get fixed for this pull request? Last time they were failing and they haven't been run lately. It also looks like this branch conflicts with |
|
recheck |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
nievesmontero
force-pushed
the
improve-error-message
branch
3 times, most recently
from
e1f36a9
to
0bf87c5
Compare
|
Build failed. ❌ unit-test RETRY_LIMIT in 7m 09s |
nievesmontero
force-pushed
the
improve-error-message
branch
3 times, most recently
from
118ce54
to
47b556a
Compare
|
Build failed. ❌ unit-test RETRY_LIMIT in 6m 55s |
nievesmontero
force-pushed
the
improve-error-message
branch
from
47b556a
to
0646411
Compare
|
Build failed. ✔️ unit-test SUCCESS in 9m 05s |
src/cmd/root.go
Outdated
| /*if utils.IsInsideContainer() && !utils.IsInsideToolboxContainer() { | ||
| return createErrorNonToolboxContainer() | ||
| }*/ | ||
|
|
There was a problem hiding this comment.
This probably is not meant to be commented out.
| /*if utils.IsInsideContainer() && !utils.IsInsideToolboxContainer() { | |
| return createErrorNonToolboxContainer() | |
| }*/ | |
| if utils.IsInsideContainer() && !utils.IsInsideToolboxContainer() { | |
| return createErrorNonToolboxContainer() | |
| } |
There was a problem hiding this comment.
It is not, however, I was testing this because if I remove the comment, all the tests fail on the CI.
There was a problem hiding this comment.
The problem in the CI is caused by the fact that when you run toolbox init-container inside the container, the /run/.toolboxenv file does not exist, because it is created by the command. So, it is a classic chicken-and-egg problem.
There was a problem hiding this comment.
Any idea on how to face this problem @HarryMichal ?
…tainer Fixes issue containers#1183 Signed-off-by: Nieves Montero <nmontero@redhat.com>
nievesmontero
force-pushed
the
improve-error-message
branch
from
0646411
to
b287838
Compare
|
Build failed. ✔️ unit-test SUCCESS in 9m 13s |
|
Build failed. ✔️ unit-test SUCCESS in 8m 38s |
I put it aside while working on the other PRs. I am stuck because of the problem mentioned here #1295 (comment) by @HarryMichal |
Fixes issue #1183
Signed-off-by: Nieves Montero nmontero@redhat.com