Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profile.d/toolbox.sh: set PS1 as explicit string constants #1514

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

profile.d/toolbox.sh: set PS1 as explicit string constants #1514

wants to merge 1 commit into from

Conversation

juhp
Copy link
Contributor

@juhp juhp commented Jun 28, 2024 •
edited
Loading

Since the PS1 strings are constants there is no need to use printf and
embed binary color codes, which also makes it hard to match on toolbox PS1.

I tested these in bash and zsh locally and they seem to work fine.

juhp added a commit to juhp/toolbox that referenced this pull request Jun 28, 2024
@juhp
profile.d/toolbox.sh: set PS1 as explicit string constants
3793a38 
since they are constants there is no need to use printf and embed
binary color codes, which also made it hard to match on toolbox PS1.

Signed-off-by: Jens Petersen <petersen@redhat.com>

containers#1514
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://softwarefactory-project.io/zuul/t/local/buildset/cc15eb9e07594ce98090ab22ec85eaa3

❌ unit-test FAILURE in 6m 05s
❌ unit-test-migration-path-for-coreos-toolbox FAILURE in 3m 06s
❌ unit-test-restricted FAILURE in 5m 52s
✔️ system-test-fedora-rawhide SUCCESS in 38m 42s
✔️ system-test-fedora-40 SUCCESS in 35m 13s
✔️ system-test-fedora-39 SUCCESS in 35m 53s
✔️ system-test-fedora-38 SUCCESS in 33m 56s

@juhp
profile.d/toolbox.sh: set bash PS1 as explicit string constant
76ec022 
since it is constant there is no need to use printf and embed
binary color codes, which also made it hard to match on toolbox PS1.

Signed-off-by: Jens Petersen <petersen@redhat.com>

containers#1514
@juhp
Copy link
Contributor Author

juhp commented Jul 1, 2024

(I dropped the zsh PS1 change, since shellcheck doesn't like $'...' quoting 🤷‍♂️)

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/9878af48e57e426dbe83b245a218fce4

✔️ unit-test SUCCESS in 5m 34s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 39s
✔️ unit-test-restricted SUCCESS in 5m 39s
✔️ system-test-fedora-rawhide SUCCESS in 37m 08s
✔️ system-test-fedora-40 SUCCESS in 36m 28s
✔️ system-test-fedora-39 SUCCESS in 37m 00s
✔️ system-test-fedora-38 SUCCESS in 35m 08s

@juhp
Copy link
Contributor Author

juhp commented Jul 7, 2024

Closing this for now in favor of #1517

@juhp juhp closed this Jul 7, 2024
@juhp juhp reopened this Oct 1, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/containers/toolbox for 1514,76ec02204ade3ca9ae7225d2b132f0847486207b

@juhp juhp mentioned this pull request Oct 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarryMichal HarryMichal Awaiting requested review from HarryMichal HarryMichal is a code owner

@debarshiray debarshiray Awaiting requested review from debarshiray debarshiray is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@juhp