refactor: pin contentful-import and contentful-export libraries [ZEND-5421] #2765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-col
approved these changes
Sep 26, 2024
jjolton-contentful
deleted the
refactor/pin-contentful-import-and-export-libraries
branch
|
🎉 This PR is included in version 3.3.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A recent problematic update to the
bfjlibrary made its way into the contentful-export package, which caused exports to output invalid json. The tests in this project correctly caught the issue and prevented contentful-export from being updated here by dependabot, but because we were using a range specifier, users installing the contentful-cli still got the bad contentful-export version.Description
Using pinned exact versions for these libraries, dependabot should still function properly and update them when changes occur, but now the tests will be required to pass before any updates make their way into this project.