Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: app installation parameter types [NONE] #2505

Merged
merged 1 commit into from
Jan 7, 2025
Merged

fix: app installation parameter types [NONE] #2505

merged 1 commit into from
Jan 7, 2025

Conversation

marcolink
Copy link
Member

@marcolink marcolink commented Jan 7, 2025 •
edited
Loading

Summary

This changes adds partially missing types to align with the types defined here.

This allows for querying app installations by spaceId.

Checklist (check all before merging)

  • Both unit and integration tests are passing
  • There are no breaking changes
  • Changes are reflected in the documentation

When adding a new method:

  • The new method is exported through the default and plain CMA client
  • All new public types are exported from ./lib/export-types.ts
  • Added a unit test for the new method
  • Added an integration test for the new method
  • The new method is added to the documentation

@marcolink marcolink requested a review from a team as a code owner January 7, 2025 08:54
@marcolink
Copy link
Member Author

This is the change that broke it in our consumer:
#2491

@marcolink marcolink merged commit 6fd5cac into master Jan 7, 2025
7 checks passed
@marcolink marcolink deleted the fix/app-installation-param-types branch January 7, 2025 16:27
@contentful-automation
Copy link
Contributor

🎉 This PR is included in version 11.40.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-col t-col t-col approved these changes

@vikaskumr vikaskumr vikaskumr approved these changes

@BasKiers BasKiers BasKiers approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcolink @BasKiers @vikaskumr @t-col