Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add rich text undo redo btns [TOL-1038] #1598

Merged
merged 3 commits into from
Mar 1, 2024
Merged

feat: add rich text undo redo btns [TOL-1038] #1598

merged 3 commits into from
Mar 1, 2024

Conversation

YvesRijckaert
Copy link
Contributor

@YvesRijckaert YvesRijckaert commented Jan 30, 2024 •
edited
Loading

Description

Adding undo and redo buttons to rich text editors
https://contentful.atlassian.net/browse/TOL-1038

Screenshot 2024-01-30 at 09 43 03

Todo

  • Add tests

@YvesRijckaert YvesRijckaert changed the title feat: add rich text undo redo btns feat: add rich text undo redo btns [TOL-1038] Jan 30, 2024
@YvesRijckaert YvesRijckaert marked this pull request as ready for review February 22, 2024 10:32
@YvesRijckaert YvesRijckaert requested a review from a team as a code owner February 22, 2024 10:32
chrishelgert
chrishelgert approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@chrishelgert chrishelgert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@aodhagan-cf
Copy link
Contributor

Is there any case where we could now have too many toolbar buttons? Also would be nice to have some component tests for this when the component test branch is merged (as a follow up)

@YvesRijckaert
Copy link
Contributor Author

Is there any case where we could now have too many toolbar buttons? Also would be nice to have some component tests for this when the component test branch is merged (as a follow up)

We already do (especially in Live Preview) 😞
I will follow up before merging this with Fidan and Fabian, but we have a ticket to make the toolbar responsive: https://contentful.atlassian.net/browse/TOL-1720

@github-actions github-actions bot added the tests label Mar 1, 2024
@YvesRijckaert YvesRijckaert force-pushed the feat/rich-text-undo branch 2 times, most recently from 44bad28 to afae649 Compare March 1, 2024 12:24
YvesRijckaert
YvesRijckaert commented Mar 1, 2024
View reviewed changes
cypress/component/rich-text/RichTextEditor.Tables.spec.ts
@@ -168,7 +168,7 @@ describe('Rich Text Editor', { viewportHeight: 2000 }, () => {
BLOCKS.HEADING_4,
BLOCKS.HEADING_5,
BLOCKS.HEADING_6,
].forEach((type) => getDropdownItem(type).get('button').should('not.be.disabled'));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colomolo I removed the .get('button') here from this test, from what I saw the getDropdownItem already selects the button, or did I miss something?

@YvesRijckaert YvesRijckaert merged commit 007db0d into master Mar 1, 2024
11 of 12 checks passed
@YvesRijckaert YvesRijckaert deleted the feat/rich-text-undo branch March 1, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aodhagan-cf aodhagan-cf aodhagan-cf approved these changes

@z0al z0al z0al left review comments

@chrishelgert chrishelgert chrishelgert approved these changes

Assignees
No one assigned
Labels
package:rich-text tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YvesRijckaert @aodhagan-cf @chrishelgert @z0al