Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update external resource entity format #1628

Merged
merged 1 commit into from
Mar 20, 2024
Merged

feat: update external resource entity format #1628

merged 1 commit into from
Mar 20, 2024

Conversation

veu
Copy link
Contributor

@veu veu commented Mar 20, 2024 •
edited
Loading

Going forward we will use urn instead of id in external resources. The property is not used anywhere yet so changing the type now won’t break anything.

@veu veu requested a review from a team March 20, 2024 07:58
@veu veu marked this pull request as ready for review March 20, 2024 07:59
@veu veu requested a review from a team as a code owner March 20, 2024 07:59
@veu veu merged commit 9221953 into master Mar 20, 2024
12 checks passed
@veu veu deleted the DANTE-1402 branch March 20, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrishelgert chrishelgert chrishelgert approved these changes

@mohamedturki mohamedturki mohamedturki approved these changes

Assignees
No one assigned
Labels
package:reference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veu @mohamedturki @chrishelgert