feat: permissions check for cross space reference editor [FUS-115] #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrishelgert
reviewed
Jan 9, 2025
| @@ -17,10 +18,18 @@ export function SingleResourceReferenceEditor( | |||
| } | |||
| ) { | |||
| const { dialogs, field } = props.sdk; | |||
|
|
|||
| const editorPermissions = useEditorPermissions({ | |||
There was a problem hiding this comment.
we could move useEditorPermissions inside of useResourceLinkActions as it's the same for single nad multiple resources :)
- NIT: instead of passing all props down, just provide the necessary ones :)
There was a problem hiding this comment.
@chrishelgert I wasn't sure where else this is used, changed it 👍
marcolink
force-pushed
the
feat/FUS-115-reference-editor-permissions
branch
from
d0855f8 to
8cb3708
Compare
|
I completely removed the |
marcolink
force-pushed
the
feat/FUS-115-reference-editor-permissions
branch
from
8cb3708 to
7c95720
Compare
|
BTW do you plan to have the checks in RichText editor too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checks permission when rendering to the Reference Editor. This check exists on the service, but we also want to check for access in the frontend for better UX. The same logic exists for "normal" same space entries.