add request_id in params and filename #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scripts/animatediff_output.py
Outdated
| @@ -31,7 +31,7 @@ def output(self, p: StableDiffusionProcessing, res: Processed, params: AnimateDi | |||
| frame_list = [image.copy() for image in res.images[i : i + params.video_length]] | |||
|
|
|||
| seq = images.get_next_sequence_number(output_dir, "") | |||
| filename = f"{seq:05}-{res.all_seeds[(i-res.index_of_first_image)]}" | |||
| filename = f"{seq:05}-{res.all_seeds[(i-res.index_of_first_image)]}-{params.request_id}" | |||
There was a problem hiding this comment.
Do not add request_id if request_id is ''
scripts/animatediff_ui.py
Outdated
| @@ -39,6 +39,7 @@ def __init__( | |||
| interp_x=10, | |||
| video_source=None, | |||
| video_path='', | |||
| request_id = '1', | |||
There was a problem hiding this comment.
put request_id at the bottom of the argument list. The default value should be ''
scripts/animatediff_ui.py
Outdated
| @@ -59,6 +60,7 @@ def __init__( | |||
| self.interp_x = interp_x | |||
| self.video_source = video_source | |||
| self.video_path = video_path | |||
| self.request_id = request_id | |||
There was a problem hiding this comment.
put request_id at the bottom of the initialization
| @@ -88,6 +90,7 @@ def get_dict(self, is_img2img: bool): | |||
| "overlap": self.overlap, | |||
| "interp": self.interp, | |||
| "interp_x": self.interp_x, | |||
| "request_id":self.request_id, | |||
There was a problem hiding this comment.
Do not add request_id if request_id is ''
scripts/animatediff_ui.py
Outdated
| value=self.params.request_id, | ||
| label="request_id", | ||
| elem_id=f"{elemid_prefix}request_id" | ||
| ) |
There was a problem hiding this comment.
People who play with WebUI do not need this element
|
thanks for your guidance , I fix it ,please review |
continue-revolution
added a commit
that referenced
this pull request
Nov 8, 2023
* add request_id in params and filename (#285) * animatediff_output.py filname add request_id * Update animatediff_ui.py AnimateDiffProcess add request_id param * allow request_id empty ,and remove from webui * move request_id at last in init method * remove request_id from webui --------- Co-authored-by: zhangruicheng <zhangruicheng@migu.cn> * fix device * request id * add test * fix test * fix test * fix test * cheaper test * cheaper test * readme * run one test at one time * readme * use ubuntu 20.04 --------- Co-authored-by: zhangrc <zrc_java@163.com> Co-authored-by: zhangruicheng <zhangruicheng@migu.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#283
#224
麻烦看看改的对不对