Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JetBrain IDE] Fix continue-binary process does not properly exit #2902

Merged
merged 1 commit into from
Nov 14, 2024
Merged

[JetBrain IDE] Fix continue-binary process does not properly exit #2902

merged 1 commit into from
Nov 14, 2024
+13 −4

Conversation

jnhyperion
Copy link
Contributor

@jnhyperion jnhyperion commented Nov 13, 2024 •
edited
Loading

Fix: #2896

ContinuePluginStartupActivity's life cycle is IDE instance level, its dispose will not be called when a project is closed.

@netlify Netlify
Copy link

netlify bot commented Nov 13, 2024 •
edited
Loading

✅ Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 0c74f93
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/67348b4468004e0008206e5b

sestinj
sestinj approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@sestinj sestinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix, thank you for taking the time to do this!

@sestinj sestinj merged commit 37a2b21 into continuedev:main Nov 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sestinj sestinj sestinj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[JetBrain IDE] continue-binary process does not properly exit when IDE project is closed
2 participants
@jnhyperion @sestinj