unsatisfied peer-dependency on typescript in v13.2.0 of @commitlint/cli

[travi]

Expected Behavior

running npm ls with @commitlint/cli installed should exit zero, meaning that there are no unsatisfied peer dependencies in the dependency tree.

Current Behavior

npm ls reports an unsatisfied peer dependency on typescript:

npm ERR! peer dep missing: typescript@>=2.7, required by ts-node@9.1.1

npm ls ts-node shows that the requirement is pulled in by @endemolshinegroup/cosmiconfig-typescript-loader:

  └─┬ @commitlint/cli@13.2.0
    └─┬ @commitlint/load@13.2.0
      └─┬ @endemolshinegroup/cosmiconfig-typescript-loader@3.0.2
        └── ts-node@9.1.1 

Affected packages

• cli
• core
• prompt
• config-angular

Possible Solution

either make @endemolshinegroup/cosmiconfig-typescript-loader an optional peer dependency or define typescript as a direct dependency of the cli package in order to satisfy the peer requirement.

Steps to Reproduce (for bugs)

1. npm install @commitlint/cli -D
2. npm ls

Context

i use commitlint in many projects that are not typescript projects, so i do not want to define typescript as a direct dependency in those projects to satisfy a peer requirement of commitlint.

Your Environment

Executable	Version
commitlint --version	13.2.0
git --version	2.27.0
node --version	14.17.5
npm --version	6.14.14

[escapedcat]

@songhn233 would you mind to provide a PR for this if you have time?
@travi thanks for opening this!

[travi]

related:

• @endemolshinegroup/cosmiconfig-typescript-loader@3.0.2 doesn't provide typescript, requested by ts-node EndemolShineGroup/cosmiconfig-typescript-loader#147
• Add typescript peer dependency EndemolShineGroup/cosmiconfig-typescript-loader#133

[escapedcat]

Ah, then it's not really our issue? Sorry for bothering @songhn233

[travi]

Ah, then it's not really our issue?

by choosing to include @endemolshinegroup/cosmiconfig-typescript-loader as a dependency, i think it becomes your issue, unfortunately. i do believe it would be better for the fix to be applied to their package directly, it looks like that has become stalled, leaving the unsatisfied peer requirement in your dependency tree.

the same fix that has been proposed in the PR against @endemolshinegroup/cosmiconfig-typescript-loader could be included here to satisfy the requirement at this level. if the problem is resolved directly in @endemolshinegroup/cosmiconfig-typescript-loader, the more local fix could be reverted at that point.

if you are open to that path forward, i would be happy to send a PR.

[escapedcat]

[...] it looks like that has become stalled, leaving the unsatisfied peer requirement in your dependency tree.

Right, then it won't work to wait for them to fix it.

the same fix that has been proposed in the PR against @endemolshinegroup/cosmiconfig-typescript-loader could be included here to satisfy the requirement at this level. if the problem is resolved directly in @endemolshinegroup/cosmiconfig-typescript-loader, the more local fix could be reverted at that point.

if you are open to that path forward, i would be happy to send a PR.

Yeah, that would be great. If the issue on their site would be resolved we can remove the fix on our side. Thanks for suggesting this!