Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select Link custom modification #924

Draft
wants to merge 12 commits into
base: dev
Choose a base branch
from
Draft

Select Link custom modification #924

wants to merge 12 commits into from

Commits on Jan 11, 2024

  1. selected-link custom modification 

    this can be used as an experimental worker version
with a custom modification of r5type select-link
adresses #913
    @abyrd
    abyrd committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    1b9df0e View commit details
    Browse the repository at this point in the history

  2. return up to 40 sorted scenario application msgs

    @abyrd
    abyrd committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    12b0013 View commit details
    Browse the repository at this point in the history

  3. tolerate routes with no explicit shapes 

    report their quantity as a scenario application info message
    @abyrd
    abyrd committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    c747d37 View commit details
    Browse the repository at this point in the history

  4. do not include select-link in ACCEPT_MODIFICATIONS 

    the result of applying this modification is transient so this wont' work
    @abyrd
    abyrd committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    6545e97 View commit details
    Browse the repository at this point in the history

  5. use addError/hasErrors instead of List interface

    @abyrd
    abyrd committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    e294e80 View commit details
    Browse the repository at this point in the history

  6. tolerate and count patterns with no gtfs 

    these should be the ones created by other modification in the scenario.
also factor out long reference chain as final List variable.
    @abyrd
    abyrd committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    e5ae1c5 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. more detail in select link path reporting 

    report route name in totals row
report proportions out of total iterations reaching destination
provide constituent rows below summary rows
    @abyrd
    abyrd committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    a4bf241 View commit details
    Browse the repository at this point in the history

  2. optionally match heading (azimuth)

    @abyrd
    abyrd committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    3105352 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. allow multiple selectLinks with labels 

    also added names as in path-route-names branch
    @abyrd
    abyrd committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    63f6770 View commit details
    Browse the repository at this point in the history

  2. list of detailed itinerary entries under summary 

    there is still no selected-link label on the detailed iterations/paths.
They are just ordered immediately below the summary including them.
    @abyrd
    abyrd committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    1d97d49 View commit details
    Browse the repository at this point in the history

  3. output only route names not ids

    @abyrd
    abyrd committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    c69be72 View commit details
    Browse the repository at this point in the history

  4. include selected link label in pseudo-column 

    always store nUnfilteredIterationsReachingDestination
    @abyrd
    abyrd committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    3aaafb9 View commit details
    Browse the repository at this point in the history