Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unecessary OAPH #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removed unecessary OAPH #1

wants to merge 1 commit into from

Conversation

giusepe
Copy link

@giusepe giusepe commented Mar 13, 2018

Changed the LoginCommand to use the return of the task in a Observable pipeline
Changed the AddCommand to use a simple sync procedure

@giusepe
Removed unecessary OAPH
cbe6a0c 
Changed the LoginCommand to use the return of the task in a Observable pipeline
Changed the AddCommand to use a simple sync procedure
@DamienDoumer
Copy link
Member

Hi, thanks for the pull request,
I saw your code and you are right, OAPH could be replaced by observables, but My aim for making the demo was to demonstrate the use of as many Reactiveui functionalities as possible.
What I will do is make another blog post where I'll mention your pull request and a way of setting can execute on commands without OAPH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giusepe @DamienDoumer