terminal

[blinkinglight]

#2298

ssh can reuse connection

ssh config
ControlMaster auto
ControlPath ~/.ssh/sockets/%r@%h-%p
ControlPersist 600

or 

ssh -t -o ControlPath=~/.ssh/master-someuniqname -o ControlMaster=auto -o ControlPersist=60 host cmd...

[blinkinglight]

https://github.com/updroidinc/cmdr-pty?tab=readme-ov-file

[LEstradioto]

Oh, that issue discussion was going forward to wanting to remove node websocket and node-pty, to not use node at all, and not needing to install node as dependency somehow. Although Im in favor of utilizing note-pty as its well known, but since a xterm.js member commented there about creating node-pty from groundup on PHP, then... I think we should ponder about that.

[blinkinglight]

https://github.com/blinkinglight/cmdr-pty what do you think? cmd in readme. ( open in browser localhost:9990 )

[LEstradioto]

Man, but then you are using Go. Coolify is Laravel !

[blinkinglight]

coolify already uses go ;) or used but will use again - coollabsio/sentinel ;)

[LEstradioto]

sentinel is not built-in, probably will be an opt-in
if Andras want Terminal to be opt-in then using Node, Go, or whatever, is the same, since its an extra process in the end

[LEstradioto]

Here's the important part of ssh connection at Coolify generateSshCommand

I see your suggestions being applied on mux_enabled. Im not sure how mux works of is it enabled by default?
I saw some interesting discussion here about ssh and cpu usage spikes
Since its high-priority issue, maybe this is being reworked.

On my PR #2586, the option changed is RequestTTY=no to then RequestTTY=yes.

But when connection happens using SSH, websocket just re-uses the ptyProcess spawned by node-pty

[LEstradioto]

(so its just one ssh command at start in this case). I think to ssh being re-used across ALL Coolify requests, ssh must be reworked on Coolify itself.

[blinkinglight]

not sure if this is to the topic but found few days ago: https://github.com/pterodactyl with https://github.com/pterodactyl/wings and https://github.com/pterodactyl/panel

seems that they uses their own worker (wings golang) on servers and dashboard (php laravel) maybe you could find some inspiration there? :)