some fixes

coolsamson7 · Nov 3, 2024 · 20d278f · 20d278f
1 parent 1380f67
commit 20d278f
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/modulefederation/libs/portal/src/lib/portal-manager.ts b/modulefederation/libs/portal/src/lib/portal-manager.ts
@@ -216,7 +216,7 @@ export class PortalManager {
     // construct lazy routes
 
     const lazyRoutes: Routes = Object.values(modules)
-      .filter((module) => module.remoteEntry !== undefined)
+      .filter((module) => module.type == "microfrontend")
       .map((module) => {
         const key = module.name;
         const feature = this.featureRegistry.getFeature(key);
@@ -375,9 +375,7 @@ export class PortalManager {
 
       this.moduleRegistry.register(module); // will keep original
 
-      if (module.remoteEntry) {
-        module.type = 'microfrontend';
-
+      if (module.type == 'microfrontend') {
         let remoteEntry = module.remoteEntry;
         if ( module.remoteEntryName)
           remoteEntry = remoteEntry + "/" + module.remoteEntryName