fix

coolsamson7 · Oct 31, 2024 · e05167a · e05167a
1 parent c224d9a
commit e05167a
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/modulefederation/apps/portal-shell/src/assets/manifest.json b/modulefederation/apps/portal-shell/src/assets/manifest.json
@@ -11,10 +11,6 @@
       "component": "HomeComponent",
       "isDefault": true
     },
-    {
-      "id": "react",
-      "label": "React"
-    },
     {
       "id": "**",
       "label": "Page not found",

diff --git a/modulefederation/libs/portal/src/lib/federation/react/react-wrapper.ts b/modulefederation/libs/portal/src/lib/federation/react/react-wrapper.ts
@@ -44,6 +44,6 @@ export class ReactComponentWrapper implements AfterContentInit, OnDestroy {
    // implement OnDestroy
 
    ngOnDestroy(): void {
-    this.root.unmount()
+    this.root?.unmount()
   }
 }