From e05167ac34499fe8475c84428e25ba63cf9c0b26 Mon Sep 17 00:00:00 2001 From: Andreas Ernst Date: Thu, 31 Oct 2024 15:27:13 +0100 Subject: [PATCH] fix --- modulefederation/apps/portal-shell/src/assets/manifest.json | 4 ---- .../libs/portal/src/lib/federation/react/react-wrapper.ts | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/modulefederation/apps/portal-shell/src/assets/manifest.json b/modulefederation/apps/portal-shell/src/assets/manifest.json index 4273b211..811be94f 100644 --- a/modulefederation/apps/portal-shell/src/assets/manifest.json +++ b/modulefederation/apps/portal-shell/src/assets/manifest.json @@ -11,10 +11,6 @@ "component": "HomeComponent", "isDefault": true }, - { - "id": "react", - "label": "React" - }, { "id": "**", "label": "Page not found", diff --git a/modulefederation/libs/portal/src/lib/federation/react/react-wrapper.ts b/modulefederation/libs/portal/src/lib/federation/react/react-wrapper.ts index 828cd03b..e62c4037 100644 --- a/modulefederation/libs/portal/src/lib/federation/react/react-wrapper.ts +++ b/modulefederation/libs/portal/src/lib/federation/react/react-wrapper.ts @@ -44,6 +44,6 @@ export class ReactComponentWrapper implements AfterContentInit, OnDestroy { // implement OnDestroy ngOnDestroy(): void { - this.root.unmount() + this.root?.unmount() } }