Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider the way channel prefixes/status modes are stored #104

Open
cooper opened this issue Jul 22, 2016 · 1 comment
Open

Reconsider the way channel prefixes/status modes are stored #104

cooper opened this issue Jul 22, 2016 · 1 comment
Assignees
Labels

Comments

@cooper
Copy link
Owner

cooper commented Jul 22, 2016

In addition to internal packages like channel.pm, Modules such as Channel::Access get information about status modes through the %ircd::channel_mode_prefixes hash. I do not like this because:

  • it is disgusting that modules are dealing with a hash directly to get config information .
  • the values of the hash are array references, making it difficult to read the code involved. this is also subject to change.
  • violates the rule of thumb that modules should not interact directly with ircd.pm.

Solution: Add method(s) to get this info. Maybe put them in utils because it seems inappropriate for ircd.pm.

@cooper cooper added the cleanup label Jul 22, 2016
@cooper
Copy link
Owner Author

cooper commented Jul 22, 2016

No. Put it in server.pm? Then call methods on $me.

@cooper cooper self-assigned this Oct 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant