Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VsCoq1] Fix IP issue with VS Code 1.82.0 #614

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Conversation

4ever2
Copy link
Contributor

@4ever2 4ever2 commented Sep 11, 2023

In VS Code 1.82.0 ipv6 is preferred during DNS resolution which is problematic since coqidetop only works with ipv4.
This patch should make VsCoq1 work with VS Code 1.82.0

Fixes coq-community/vscoq-legacy#52

@thery
Copy link
Contributor

thery commented Sep 11, 2023

@rtetley @maximedenes maybe it would be worth making a new release of vscoq1 just for that fixes. What do you think?

@thery
Copy link
Contributor

thery commented Sep 11, 2023

@4ever2 Thanks

@thery thery merged commit e759426 into coq:vscoq1 Sep 11, 2023
@4ever2 4ever2 deleted the ipv6-fix branch September 11, 2023 12:41
@rtetley
Copy link
Collaborator

rtetley commented Sep 11, 2023

@thery I would say let's do it ! There does not seem to be other changes to vscoq 1 ? Maybe the message panel ? I don't know what the status is regarding that

@4ever2
Copy link
Contributor Author

4ever2 commented Sep 11, 2023

If there is going to be another release then I think we should merge some of the smaller fixes contained in the open pull requests. Such as search in proofview and the -topfile fix.

@thery
Copy link
Contributor

thery commented Sep 11, 2023

@4ever2 still have problem with 1.82.0. Now coqtop starts but there is no update of goals.
I will see if the problem is only local to me. Anyway which PRs are you refeering too?

@4ever2
Copy link
Contributor Author

4ever2 commented Sep 11, 2023

@thery I don't quite see how that can be cause by this change. The DNS setting should be local to just the server. The webview/rendering of the goal is done in the client. Maybe something else in 1.82.0 is causing it?

The second commit of #319 contains a fix for the -topfile argument being passed the wrong value. #320 contains a change that enables search in the proofview. I would be happy to extract these changes from the PRs if you agree that these would be useful have.

@thery
Copy link
Contributor

thery commented Sep 12, 2023

@4ever2 ok starting from scratch 1.82.0 now works for me.

I would be happy to extract these changes from the PRs if you agree that these would be useful have.

Please do, having a new release this week would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants