Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acknowledge webhook creation ping #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mhkeller
Copy link

GitHub sends a ping even on Webhook creation: https://developer.github.com/webhooks/#ping-event

But since it doesn't follow the structure that lib/index.js is expecting, that script throws an error, such as when it can't find a string for payload.ref.

You could do fancier things to handle this such as emit a ping event but this fix will stop the script from breaking for now.

@mhkeller
Copy link
Author

Checking in on this.

@ScottONeal
Copy link

@mhkeller if you're still using this library, I've created a fork which supports Ping events and has unit tests.

Check it out at: https://www.npmjs.com/package/githooked

@mhkeller
Copy link
Author

mhkeller commented Feb 7, 2016

@ScottONeal awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants