From fad6461b6ebda1ba7bf82c7712c5440832f363e1 Mon Sep 17 00:00:00 2001 From: Jonathan Lebon Date: Wed, 27 Nov 2024 10:59:58 -0500 Subject: [PATCH] testiso: use ostree version for offline version check There is a difference between the build ID and the OSTree version. They're almost always the same, except if you're rebuilding disk images/ISOs on top of the same OSTree commit. Here, we want the OSTree version, not the build ID. --- mantle/cmd/kola/testiso.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mantle/cmd/kola/testiso.go b/mantle/cmd/kola/testiso.go index a740b6810c..9dfad1bc7e 100644 --- a/mantle/cmd/kola/testiso.go +++ b/mantle/cmd/kola/testiso.go @@ -819,7 +819,7 @@ func testPXE(ctx context.Context, inst platform.Install, outdir string) (time.Du liveConfig.AddSystemdUnit("coreos-test-entered-emergency-target.service", signalFailureUnit, conf.Enable) if isOffline { - contents := fmt.Sprintf(downloadCheck, kola.CosaBuild.Meta.BuildID, kola.CosaBuild.Meta.OstreeCommit) + contents := fmt.Sprintf(downloadCheck, kola.CosaBuild.Meta.OstreeVersion, kola.CosaBuild.Meta.OstreeCommit) liveConfig.AddSystemdUnit("coreos-installer-offline-check.service", contents, conf.Enable) }