osbuild: Add Live ISO/PXE build support #3976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
dustymabe
force-pushed
the
dusty-osbuild-live-iso-pxe
branch
from
f902e80 to
7a95e07
Compare
Since we are going to modify it let's ensure it's writable. We are changing up some of the code that builds the Live artifacts and it exposed the fact that we are relying here on the files in the builddir to have the writable bit set. Let's not rely on that.
In 230139d we started copying in `src/config/live` into an overlay to be stored under `/usr/share/coreos-assembler/live` in our resulting images. The way this is currently implemented yields a nested `live/live` folder and duplicate contents getting created becuase we don't clean up between runs: ``` /srv/tmp/override/usr-share-cosa/usr/share/coreos-assembler/live/README-devel.md /srv/tmp/override/usr-share-cosa/usr/share/coreos-assembler/live/zipl.prm /srv/tmp/override/usr-share-cosa/usr/share/coreos-assembler/live/isolinux /srv/tmp/override/usr-share-cosa/usr/share/coreos-assembler/live/isolinux/isolinux.cfg /srv/tmp/override/usr-share-cosa/usr/share/coreos-assembler/live/isolinux/boot.msg /srv/tmp/override/usr-share-cosa/usr/share/coreos-assembler/live/EFI /srv/tmp/override/usr-share-cosa/usr/share/coreos-assembler/live/EFI/fedora /srv/tmp/override/usr-share-cosa/usr/share/coreos-assembler/live/EFI/fedora/grub.cfg /srv/tmp/override/usr-share-cosa/usr/share/coreos-assembler/live/live /srv/tmp/override/usr-share-cosa/usr/share/coreos-assembler/live/live/README-devel.md /srv/tmp/override/usr-share-cosa/usr/share/coreos-assembler/live/live/zipl.prm /srv/tmp/override/usr-share-cosa/usr/share/coreos-assembler/live/live/isolinux /srv/tmp/override/usr-share-cosa/usr/share/coreos-assembler/live/live/isolinux/isolinux.cfg /srv/tmp/override/usr-share-cosa/usr/share/coreos-assembler/live/live/isolinux/boot.msg /srv/tmp/override/usr-share-cosa/usr/share/coreos-assembler/live/live/EFI /srv/tmp/override/usr-share-cosa/usr/share/coreos-assembler/live/live/EFI/fedora /srv/tmp/override/usr-share-cosa/usr/share/coreos-assembler/live/live/EFI/fedora/grub.cfg ``` This results in the same being duplicated in our images. Let's clean up between runs so we can not have the duplicate folder/files.
dustymabe
force-pushed
the
dusty-osbuild-live-iso-pxe
branch
from
7a95e07 to
91b470a
Compare
|
currently this is still WIP but it's getting closer. |
dustymabe
force-pushed
the
dusty-osbuild-live-iso-pxe
branch
3 times, most recently
from
7c2affe to
2291091
Compare
jlebon
force-pushed
the
dusty-osbuild-live-iso-pxe
branch
from
2291091 to
d8e6a15
Compare
We run osbuild inside of supermin, so for building the live ISO we'll need all the tools it needs in there. We don't currently name `squashfs-tools` as a toplevel dependency. It's currently pulled in by libguestfs, but we need it in supermin too, so explicitly list it there.
jlebon
force-pushed
the
dusty-osbuild-live-iso-pxe
branch
from
d8e6a15 to
4be456d
Compare
|
Pushed a few minor fixes.
I'm pretty comfortable with getting this in and turning it on in rawhide at this point. |
jlebon
previously approved these changes
Nov 27, 2024
|
Also, I think I'll turn it on in the 9.6 streams in RHCOS since those are not being consumed yet by a wider audience and I didn't test RHCOS with this change so far (though I don't really expect any issues). It'll also make it easier for the AI/ABI folks to poke at it, and bundling it with 9.6 is a nice switchover point so that it gets validated in OCP together with 9.6 validation. |
dustymabe
force-pushed
the
dusty-osbuild-live-iso-pxe
branch
from
4be456d to
23b4076
Compare
This backports and takes advantage of the new org.osbuild.coreos.live-artifacts.mono stage. Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
- Add checkpoints for metal and metal4k pipelines due LiveISO builds; - Bump cache size from 14G to 20G. Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
There is a difference between the build ID and the OSTree version. They're almost always the same, except if you're rebuilding disk images/ISOs on top of the same OSTree commit. Here, we want the OSTree version, not the build ID.
Might as well make it a meaningful CI run.
jlebon
force-pushed
the
dusty-osbuild-live-iso-pxe
branch
from
23b4076 to
54197e5
Compare
jlebon
approved these changes
Nov 27, 2024
|
Test fixture option seems to be working fine: which is in line with sizes in https://github.com/coreos/coreos-installer/tree/main/fixtures/iso once compressed. Using e.g. |
|
I see that we added a few more patches to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports and takes advantage of the new
org.osbuild.coreos.live-artifacts.mono stage.