chore: Bump go-jose dependency and mod tidy #418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bumps the go-jose dependency to a version that addresses vulnerability CVE-2024-28180. Closes coreos#417
ericchiang
reviewed
Mar 19, 2024
There was a problem hiding this comment.
Don't know why the toolchain directive was added, but I'm not seeing that locally
% go get github.com/go-jose/go-jose/v3@v3.0.3
go: downloading github.com/go-jose/go-jose/v3 v3.0.3
go: downloading golang.org/x/crypto v0.19.0
go: upgraded github.com/go-jose/go-jose/v3 v3.0.1 => v3.0.3
go: upgraded golang.org/x/crypto v0.14.0 => v0.19.0
% go mod tidy
go: downloading golang.org/x/net v0.17.0
go: downloading google.golang.org/appengine v1.6.8
% cat go.mod
module github.com/coreos/go-oidc/v3
go 1.19
require (
github.com/go-jose/go-jose/v3 v3.0.3
golang.org/x/net v0.17.0
golang.org/x/oauth2 v0.13.0
)
require (
github.com/golang/protobuf v1.5.3 // indirect
golang.org/x/crypto v0.19.0 // indirect
google.golang.org/appengine v1.6.8 // indirect
google.golang.org/protobuf v1.31.0 // indirect
)
| @@ -1,17 +1,19 @@ | |||
| module github.com/coreos/go-oidc/v3 | |||
|
|
|||
| go 1.19 | |||
| go 1.21 | |||
There was a problem hiding this comment.
To the best of my knowledge, this directive describes "this package can only be used with go 1.21 and up." But this package works fine with older versions
| go 1.19 | ||
| go 1.21 | ||
|
|
||
| toolchain go1.21.5 |
There was a problem hiding this comment.
Wouldn't expect us to pin a specific toolchain version like this
|
@ericchiang sorry but I could only get to this now. You're right, I let these changes slide in with my local setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the go-jose dependency to a version that addresses vulnerability CVE-2024-28180.
Tested with the below:
Closes #417