Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treefile: Add ignore-devices #5114

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Commits on Oct 14, 2024

  1. treefile: Add ignore-devices

    We hit another case where people are pulling a container image
    with devices in `/dev` in the tar stream; they're then trying
    to commit this to an ostree.
    
    There's much better ways to fix this:
    
    - Change the image to stop including devices as there's no reason
      to do so
    - Switch to logically bound images instead of physically bound
    - Use the composefs backend for c/storage
    
    Eventually I may look at "quoting" generally in ostree, but
    it's fairly invasive: ostreedev/ostree#2568
    
    In practice today, simply ignoring the files will happen to work
    for "podman run" of such images; podman will just use overlayfs
    to stitch together the `diff` directories, and doesn't try to do
    any validation of their contents today.
    (Queue the composefs integration, which *would* do that but would
     also fix this anwyays)
    
    Signed-off-by: Colin Walters <walters@verbum.org>
    cgwalters committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    8bc826c View commit details
    Browse the repository at this point in the history