Various fixes #544
Closed
Various fixes #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jQuery fixes (config was ignored, if given as parameter) coreui#2
|
I will close this and add each fix into a separate merge request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request consists of three fixes:
Bootstrap-version JS generation
In the current state, Core UI Bootstrap JS is not really bootstrap compatible. All data attributes are expected to be data-coreui instead of data-bs, as with Bootstrap. This basically breaked a lot of Boostrap code.
Fixed this.
Also fixed coreui.io website being written wrong in the source as bs.io.
data-coreui-toggle="loading-button" prevents submitting action
For example, clicking this button this won't trigger submit:
<button type="submit" data-coreui-toggle="loading-button">Save</button>jQuery fixes (config was ignored, if given as parameter)
For example, as of currently, passing config via jQuery to a rating component is ignored. For example
$('#myRating').rating({ name: 'rating' })does the same as$('#myRating').rating(). Obviously a bug.