Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Corretto-21 images, update github actions #179

Merged
merged 10 commits into from
Sep 18, 2023
Merged

Conversation

mrserb
Copy link
Contributor

@mrserb mrserb commented Sep 15, 2023

Description of changes:

Adding Corretto-21 images using the similar approach we did for 17 and 20. The difference from 20 is that we do not have al2023-generic.

@mrserb mrserb marked this pull request as draft September 15, 2023 17:48
Copy link
Contributor

@lutkerd lutkerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We won't have AL2 with the platform RPMs just the generic

@lutkerd
Copy link
Contributor

lutkerd commented Sep 15, 2023

I don't see changes to bin/apply-template.py or versions.json, were those missed?

@benty-amzn
Copy link
Contributor

I don't see changes to bin/apply-template.py or versions.json, were those missed?

versions.json is there but +1 for the missing script changes

@mrserb
Copy link
Contributor Author

mrserb commented Sep 15, 2023

The work still in progress, the PR is in draft.

@mrserb mrserb marked this pull request as ready for review September 15, 2023 19:18
@mrserb
Copy link
Contributor Author

mrserb commented Sep 15, 2023

Do I need to update tags manually as well?

@lutkerd
Copy link
Contributor

lutkerd commented Sep 15, 2023

Do I need to update tags manually as well?

Run the script locally to make sure it worked, the is an GHA to run it after you merge and add the comment on your commit.

@mrserb
Copy link
Contributor Author

mrserb commented Sep 15, 2023

bash bin/update-dockerfiles.sh
and
python3 bin/tag-generator.py | tee .tags
do not produce any errors

@lutkerd
Copy link
Contributor

lutkerd commented Sep 18, 2023

missing test/test-image-corretto21-jre.yaml to fix the last 2 failures.

@mrserb
Copy link
Contributor Author

mrserb commented Sep 18, 2023

all checks are passed

@mrserb mrserb merged commit 78ab1e3 into corretto:main Sep 18, 2023
@mrserb mrserb deleted the jdk21 branch September 18, 2023 18:10
@CasaSky
Copy link

CasaSky commented Sep 20, 2023

can i access to the docker image of corretto 21?
docker pull amazoncorretto:21
fails with
Error response from daemon: manifest for amazoncorretto:21 not found: manifest unknown: manifest unknown

@SentryMan
Copy link

can i access to the docker image of corretto 21? docker pull amazoncorretto:21 fails with Error response from daemon: manifest for amazoncorretto:21 not found: manifest unknown: manifest unknown

I'm also getting this

@fbellomi
Copy link

can i access to the docker image of corretto 21? docker pull amazoncorretto:21 fails with Error response from daemon: manifest for amazoncorretto:21 not found: manifest unknown: manifest unknown

I'm also getting this

+1

@benty-amzn
Copy link
Contributor

The corretto 21 images have not been published to official-images/amazoncorretto yet. We expect them to be available soon and we'll post an update here when they're ready.

@benty-amzn
Copy link
Contributor

official-images#15408 is the PR for the update. Once that's merged images should be available on dockerhub and ecr gallery within a few hours.

WithEnoughCoffee pushed a commit to WithEnoughCoffee/corretto-docker that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants