This repository has been archived by the owner on Jan 5, 2024. It is now read-only.
Custom Pan Value for SoundContainers #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Causeless
reviewed
Dec 16, 2023
| @@ -602,6 +602,11 @@ namespace RTE { | |||
| result = (result == FMOD_OK) ? channel->setPriority(soundContainer->GetPriority()) : result; | |||
| float pitchVariationMultiplier = pitchVariationFactor == 1.0F ? 1.0F : RandomNum(1.0F / pitchVariationFactor, 1.0F * pitchVariationFactor); | |||
| result = (result == FMOD_OK) ? channel->setPitch(soundContainer->GetPitch() * pitchVariationMultiplier) : result; | |||
|
|
|||
| if (soundContainer->GetCustomPanValue() != 0.0f) { | |||
There was a problem hiding this comment.
What happens if you set the pan to, for example, 1, and then try to reset it to 0? Will it stay at 1?
| @@ -807,7 +812,7 @@ namespace RTE { | |||
| void *userData; | |||
| result = result == FMOD_OK ? soundChannel->getUserData(&userData) : result; | |||
| const SoundContainer *soundContainer = static_cast<SoundContainer *>(userData); | |||
| if (sqrDistanceToPlayer < (m_MinimumDistanceForPanning * m_MinimumDistanceForPanning)) { | |||
| if (sqrDistanceToPlayer < (m_MinimumDistanceForPanning * m_MinimumDistanceForPanning) || soundContainer->GetCustomPanValue() != 0.0f) { | |||
There was a problem hiding this comment.
We're already saying no guarantees for non-immobile sounds, why add this check?
network stuff there Just In Case, and to conform with what's already there. it's entirely pointless, but it was that or rename this branch remove-multiplayer
Causeless
approved these changes
Dec 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds CustomPanValue R/W ini lua property from -1.0f to 1.0f for hard-overriding left-right panning. on non-immobile sounds, volume and EQ attenuation will still occur, but the sound will remain in the exact position that is set.
not setting it, or setting it back to 0, will enable default spatial panning behavior. for disabling panning outright PanningStrengthMultiplier should be used, so this 0-to-reset deal is fine.
currently used for refinery ambiences, so the oneshots are placed around in the stereo soundscape instead of always center.