Add ability to specify list of ignored Nomad meta labels #46
+32
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
We are actively using Nomad for developments and testing apps and push various deployment info to Nomad's meta such as time of deployment, author, pipeline id and other similar things that help to identify exact revision.
This leads to huge amount of unique labels on Cilium that creates new Identity for them exhausting free identities very fast.
New option provides ability to ignore specified metadata keys when Netreap labeling Cilium endpoints.
Related Issues
Consumer Impact
Can reduce amount of identities created by Cilium.
Without specifying any values Netreap behaviour won't change.
Testing
Built on platform(s)
Tested on platform(s)
Unit Test(s)
Manual Verification
Built changed version without new parameter/env var, deployed to Nomad. Behaviour didn't change.
Specified some values for env var, that label absent from Cilium.