Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add unit test for assert for increase coverage to 100% #1518

Merged
merged 3 commits into from
Dec 8, 2023
Merged

test: add unit test for assert for increase coverage to 100% #1518

merged 3 commits into from
Dec 8, 2023

Conversation

hyperbolic-versor
Copy link
Contributor

add unit test for assert function, make @cosmjs/utils test coverage to 100%

@webmaster128
Copy link
Member

Nice, thanks. Could you run yarn && yarn lint-fix to make the linter happy?

@hyperbolic-versor
Copy link
Contributor Author

Nice, thanks. Could you run yarn && yarn lint-fix to make the linter happy?

Thank you for your reminder. I forgot again.
I think we can add a Git hook to check lint and unit tests before push or commit."

@webmaster128
Copy link
Member

webmaster128 commented Dec 8, 2023 •
edited
Loading

Nah, git hooks are super annoying. CI takes care of that. Thanks!

@webmaster128 webmaster128 merged commit 97a54b8 into cosmos:main Dec 8, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyperbolic-versor @webmaster128