Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set date in advance during faucet to prevent multiple requests from the same address #1561

Merged
merged 1 commit into from
Feb 27, 2024
Merged

fix: set date in advance during faucet to prevent multiple requests from the same address #1561

merged 1 commit into from
Feb 27, 2024
+1 −1

Conversation

170210
Copy link
Contributor

@170210 170210 commented Feb 27, 2024 •
edited
Loading

Since the await faucet.credit(address, matchingDenom) call only returns when the transaction is in a block, the date is set too late. We should swap the two.

close #1556

@170210
fix: set date in advance to prevent multiple requests from the same a…
19251b9 
…ddress

Signed-off-by: 170210 <j170210@icloud.com>
webmaster128
webmaster128 approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@webmaster128 webmaster128 merged commit 11ce122 into cosmos:main Feb 27, 2024
16 checks passed
@170210 170210 deleted the fix_captcha branch February 28, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rapidly sending multiple requests to the faucet can obtain multiple test coins
2 participants
@170210 @webmaster128