fix rpc client node info check #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
approved these changes
Jun 6, 2024
assafmo
added a commit
to Stride-Labs/cw-hyperlane
that referenced
this pull request
Jul 2, 2024
for more info see cosmos/cosmjs#1591
byeongsu-hong
pushed a commit
to many-things/cw-hyperlane
that referenced
this pull request
Jul 3, 2024
for more info see cosmos/cosmjs#1591
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
channels field from the node info is specifically used by cometbft p2p system, but in cases like rollkit where that is not used this can be an empty string.
This changes the assert from not empty to only assert is string that was preventing stargate client to initialize correctly.
see example:
https://rpc.rosm.rollkit.dev/status